fix: look for the passwords in the particular realm, not all the pass…

…words (#162) Similar to splunk/addonfactory-solutions-library-python#189. This change should fix the situation when you try to get a specific password for you add-on and some other password in other add-on is corrupted, then the configuration page is not loading for all the add-ons.
splunk · Sep 1, 2022 · 326ffa1 · 326ffa1
1 parent 5ddf197
commit 326ffa1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 33 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -23,11 +23,11 @@ license = "APACHE-2.0"
 
 [tool.poetry.dependencies]
 python = "^3.7"
-solnlib = "^4.0.0"
 splunktalib = "^3.0.0"
 requests = "^2.26.0"
 PySocks = "^1.7.1"
 splunk-sdk = ">=1.6.18"
+solnlib = "^4.7.0"
 
 [tool.poetry.dev-dependencies]
 pytest = "^7.1"

diff --git a/splunktaucclib/rest_handler/credentials.py b/splunktaucclib/rest_handler/credentials.py
@@ -289,9 +289,7 @@ def decrypt_all(self, data):
             host=self._splunkd_info.hostname,
             port=self._splunkd_info.port,
         )
-
-        all_passwords = credential_manager._get_all_passwords()
-        # filter by realm
+        all_passwords = credential_manager.get_clear_passwords_in_realm()
         realm_passwords = [x for x in all_passwords if x["realm"] == self._realm]
         return self._merge_passwords(data, realm_passwords)