Fix flaky. Workaround for SQLite driver bug returning a result before the commit. #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug on SQLite driver, which makes it return a result before the actual commit.
When using
fetch_one()
for queries with a RETURNING clause, the query prematurely returns after fetching the first result row without ensuring the SQLite statement is fully completed.This bug was causing the test
test_sqlite_repository_read_only()
to fail sometimes when creating a database atseafowl/src/repository/default.rs
Lines 142 to 143 in 8a47781
In this PR, I implement a workaround by manually starting a transaction before running the query and committing it afterwards.
Flaky failure example:
https://github.com/splitgraph/seafowl/actions/runs/10721496337/job/29730146388