Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text color to callout #44

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Add text color to callout #44

merged 2 commits into from
Jan 7, 2021

Conversation

janniks
Copy link
Contributor

@janniks janniks commented Dec 20, 2020

The text color of callouts is missing. Background color works, but there are no non-background _co css rules in styles.css, so text coloring of callouts does not work yet.


I fixed this by adding the same class without the _co before the existing class. This way the text color (first class) will not be overwritten (e.g. because no .notion-teal_co rule exists) and the background color will still use the custom _co rules (e.g. because .notion-teal_backgorund is overwritten by.notion-teal_backgorund_co)

You can see the working callout text color in the first block of this Notion page: 8c1ab01960b049f6a282dda64a94afc7

@tobiaslins tobiaslins merged commit d7427f3 into splitbee:master Jan 7, 2021
@tobiaslins
Copy link
Member

Thank you @janniks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants