[Rector] Apply SetList::DEAD_CODE

rector.php

@@ -3,8 +3,13 @@
 declare(strict_types=1);
 
 use Rector\Core\Configuration\Option;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
+use Rector\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector;
 use Rector\Php71\Rector\FuncCall\CountOnNullRector;
 use Rector\Set\ValueObject\LevelSetList;
+use Rector\Set\ValueObject\SetList;
+use Spiral\Boot\Bootloader\ConfigurationBootloader;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
@@ -15,7 +20,18 @@
 
     $parameters->set(Option::SKIP, [
         CountOnNullRector::class,
+
+        // for PHP 8
+        RemoveUnusedPromotedPropertyRector::class,
+
+        // buggy when remove private property, but filled by construct in the middle of parameter
+        RemoveUnusedPrivatePropertyRector::class,
+
+        RemoveUnusedPrivateMethodRector::class => [
+            __DIR__ . '/src/Boot/src/Bootloader/ConfigurationBootloader.php',
+        ],
     ]);
 
     $containerConfigurator->import(LevelSetList::UP_TO_PHP_72);
+    $containerConfigurator->import(SetList::DEAD_CODE);
 };

src/AnnotatedRoutes/src/Bootloader/AnnotatedRoutesBootloader.php

@@ -44,21 +44,12 @@ final class AnnotatedRoutesBootloader extends Bootloader implements SingletonInt
     /** @var GroupRegistry */
     private $groups;
 
-    /**
-     * @param MemoryInterface $memory
-     * @param GroupRegistry   $groupRegistry
-     */
     public function __construct(MemoryInterface $memory, GroupRegistry $groupRegistry)
     {
         $this->memory = $memory;
         $this->groups = $groupRegistry;
     }
 
-    /**
-     * @param EnvironmentInterface $env
-     * @param ConsoleBootloader    $console
-     * @param RouteLocator         $locator
-     */
     public function boot(ConsoleBootloader $console, EnvironmentInterface $env, RouteLocator $locator): void
     {
         $console->addCommand(ResetCommand::class);
@@ -79,17 +70,11 @@ public function boot(ConsoleBootloader $console, EnvironmentInterface $env, Rout
         }
     }
 
-    /**
-     * @return GroupRegistry
-     */
     public function getGroups(): GroupRegistry
     {
         return $this->groups;
     }
 
-    /**
-     * @param array $routes
-     */
     private function configureRoutes(array $routes): void
     {
         foreach ($routes as $name => $schema) {

src/AnnotatedRoutes/src/Command/ResetCommand.php

@@ -20,9 +20,6 @@ final class ResetCommand extends Command
     protected const NAME        = 'route:reset';
     protected const DESCRIPTION = 'Reset route cache';
 
-    /**
-     * @param MemoryInterface $memory
-     */
     public function perform(MemoryInterface $memory): void
     {
         $memory->saveData(AnnotatedRoutesBootloader::MEMORY_SECTION, null);

src/AnnotatedRoutes/src/GroupRegistry.php

@@ -25,18 +25,11 @@ final class GroupRegistry implements \IteratorAggregate
     /** @var RouteGroup[] */
     private $groups = [];
 
-    /**
-     * @param FactoryInterface $factory
-     */
     public function __construct(FactoryInterface $factory)
     {
         $this->factory = $factory;
     }
 
-    /**
-     * @param string $name
-     * @return RouteGroup
-     */
     public function getGroup(string $name): RouteGroup
     {
         if (!isset($this->groups[$name])) {

src/AnnotatedRoutes/src/RouteGroup.php

@@ -41,11 +41,6 @@ final class RouteGroup
     /** @var CoreInterface */
     private $core;
 
-    /**
-     * @param ContainerInterface $container
-     * @param RouterInterface    $router
-     * @param Pipeline           $pipeline
-     */
     public function __construct(
         ContainerInterface $container,
         RouterInterface $router,
@@ -58,9 +53,6 @@ public function __construct(
 
     /**
      * Prefix added to all the routes.
-     *
-     * @param string $prefix
-     * @return $this
      */
     public function setPrefix(string $prefix): self
     {
@@ -74,7 +66,6 @@ public function setPrefix(string $prefix): self
 
     /**
      * @param CoreInterface|string|Autowire $core
-     * @return $this
      */
     public function setCore($core): self
     {
@@ -91,7 +82,6 @@ public function setCore($core): self
 
     /**
      * @param MiddlewareInterface|string $middleware
-     * @return $this
      */
     public function addMiddleware($middleware): self
     {
@@ -109,14 +99,6 @@ public function addMiddleware($middleware): self
 
     /**
      * Register route to group.
-     *
-     * @param string $name
-     * @param string $pattern
-     * @param string $controller
-     * @param string $action
-     * @param array  $verbs
-     * @param array  $defaults
-     * @param array  $middleware
      */
     public function registerRoute(
         string $name,
@@ -156,12 +138,6 @@ public function flushRoutes()
         }
     }
 
-    /**
-     * @param string $pattern
-     * @param string $controller
-     * @param string $action
-     * @return Route
-     */
     public function createRoute(string $pattern, string $controller, string $action): Route
     {
         $action = new Action($controller, $action);

src/AnnotatedRoutes/src/RouteLocator.php

@@ -19,17 +19,11 @@ final class RouteLocator
     /** @var AnnotationLocator */
     private $locator;
 
-    /**
-     * @param AnnotationLocator $locator
-     */
     public function __construct(AnnotationLocator $locator)
     {
         $this->locator = $locator;
     }
 
-    /**
-     * @return array
-     */
     public function findDeclarations(): array
     {
         $result = [];

src/Annotations/src/AnnotatedClass.php

@@ -20,7 +20,6 @@ final class AnnotatedClass
     private $annotation;
 
     /**
-     * @param \ReflectionClass $class
      * @param mixed            $annotation
      */
     public function __construct(\ReflectionClass $class, $annotation)
@@ -29,9 +28,6 @@ public function __construct(\ReflectionClass $class, $annotation)
         $this->annotation = $annotation;
     }
 
-    /**
-     * @return \ReflectionClass
-     */
     public function getClass(): \ReflectionClass
     {
         return $this->class;

src/Annotations/src/AnnotatedMethod.php

@@ -20,7 +20,6 @@ final class AnnotatedMethod
     private $annotation;
 
     /**
-     * @param \ReflectionMethod $method
      * @param mixed             $annotation
      */
     public function __construct(\ReflectionMethod $method, $annotation)
@@ -29,17 +28,11 @@ public function __construct(\ReflectionMethod $method, $annotation)
         $this->annotation = $annotation;
     }
 
-    /**
-     * @return \ReflectionClass
-     */
     public function getClass(): \ReflectionClass
     {
         return $this->method->getDeclaringClass();
     }
 
-    /**
-     * @return \ReflectionMethod
-     */
     public function getMethod(): \ReflectionMethod
     {
         return $this->method;

src/Annotations/src/AnnotatedProperty.php

@@ -20,7 +20,6 @@ final class AnnotatedProperty
     private $annotation;
 
     /**
-     * @param \ReflectionProperty $property
      * @param mixed               $annotation
      */
     public function __construct(\ReflectionProperty $property, $annotation)
@@ -29,17 +28,11 @@ public function __construct(\ReflectionProperty $property, $annotation)
         $this->annotation = $annotation;
     }
 
-    /**
-     * @return \ReflectionClass
-     */
     public function getClass(): \ReflectionClass
     {
         return $this->property->getDeclaringClass();
     }
 
-    /**
-     * @return \ReflectionProperty
-     */
     public function getProperty(): \ReflectionProperty
     {
         return $this->property;

src/Annotations/src/AnnotationLocator.php

@@ -32,9 +32,7 @@ final class AnnotationLocator implements SingletonInterface
     /**
      * AnnotationLocator constructor.
      *
-     * @param ClassesInterface      $classLocator
      * @param AnnotationReader|null $reader
-     *
      * @throws \Doctrine\Common\Annotations\AnnotationException
      */
     public function __construct(ClassesInterface $classLocator, AnnotationReader $reader = null)
@@ -45,9 +43,6 @@ public function __construct(ClassesInterface $classLocator, AnnotationReader $re
 
     /**
      * Limit locator to only specific class types.
-     *
-     * @param array $targets
-     * @return AnnotationLocator
      */
     public function withTargets(array $targets): self
     {
@@ -60,7 +55,6 @@ public function withTargets(array $targets): self
     /**
      * Find all classes with given annotation.
      *
-     * @param string $annotation
      * @return iterable|AnnotatedClass[]
      */
     public function findClasses(string $annotation): iterable
@@ -76,7 +70,6 @@ public function findClasses(string $annotation): iterable
     /**
      * Find all methods with given annotation.
      *
-     * @param string $annotation
      * @return iterable|AnnotatedMethod[]
      */
     public function findMethods(string $annotation): iterable
@@ -94,7 +87,6 @@ public function findMethods(string $annotation): iterable
     /**
      * Find all properties with given annotation.
      *
-     * @param string $annotation
      * @return iterable|AnnotatedProperty[]
      */
     public function findProperties(string $annotation): iterable

src/Attributes/src/Bridge/DoctrineReaderBridge.php

@@ -42,9 +42,6 @@ final class DoctrineReaderBridge implements Reader
      */
     private ReaderInterface $reader;
 
-    /**
-     * @param ReaderInterface $reader
-     */
     public function __construct(ReaderInterface $reader)
     {
         $this->reader = $reader;

src/Attributes/src/Composite/Composite.php

@@ -82,13 +82,11 @@ public function getParameterMetadata(\ReflectionParameter $parameter, string $na
 
     /**
      * @param callable(ReaderInterface): list<array-key, object> $resolver
-     * @return iterable
      */
     abstract protected function each(callable $resolver): iterable;
 
     /**
      * @param \Traversable|array $result
-     * @return array
      */
     protected function iterableToArray(iterable $result): array
     {

src/Attributes/src/Factory.php

@@ -26,7 +26,6 @@ class Factory implements FactoryInterface
 
     /**
      * @param CacheInterface|CacheItemPoolInterface|null $cache
-     * @return $this
      */
     public function withCache($cache): self
     {
@@ -50,10 +49,6 @@ public function create(): ReaderInterface
         );
     }
 
-    /**
-     * @param ReaderInterface $reader
-     * @return ReaderInterface
-     */
     private function decorateByAnnotations(ReaderInterface $reader): ReaderInterface
     {
         if (\interface_exists(DoctrineReaderInterface::class)) {
@@ -65,10 +60,6 @@ private function decorateByAnnotations(ReaderInterface $reader): ReaderInterface
         return $reader;
     }
 
-    /**
-     * @param ReaderInterface $reader
-     * @return ReaderInterface
-     */
     private function decorateByCache(ReaderInterface $reader): ReaderInterface
     {
         switch (true) {

src/Attributes/src/FactoryInterface.php

@@ -13,8 +13,5 @@
 
 interface FactoryInterface
 {
-    /**
-     * @return ReaderInterface
-     */
     public function create(): ReaderInterface;
 }