Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GuardScope to operate within container scopes #1146

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

roxblnfk
Copy link
Member

The container is passed through a proxy now

@roxblnfk roxblnfk requested a review from a team September 11, 2024 09:41
*/
final class GuardScope implements GuardInterface
{
private ?ActorInterface $actor = null;

public function __construct(
private readonly PermissionsInterface $permissions,
private readonly ContainerInterface $container,
#[Proxy] private readonly ContainerInterface $container,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, this works.

@roxblnfk roxblnfk merged commit 45379ec into master Sep 11, 2024
12 checks passed
@roxblnfk roxblnfk deleted the scoped-guard-scope branch September 11, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants