Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion via ignoring Proxy in ContainerScope #1145

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

roxblnfk
Copy link
Member

This is internal behavior.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.74%. Comparing base (a21bf32) to head (727e1a8).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/Core/src/Internal/Proxy/Resolver.php 38.46% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1145      +/-   ##
============================================
- Coverage     89.77%   89.74%   -0.03%     
- Complexity     6491     6500       +9     
============================================
  Files           854      854              
  Lines         18441    18470      +29     
============================================
+ Hits          16555    16576      +21     
- Misses         1886     1894       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit c1ff081 into master Sep 10, 2024
13 of 14 checks passed
@roxblnfk roxblnfk changed the title Fix recursion via ignoring Proxy in ContainerScope (#1140) Fix recursion via ignoring Proxy in ContainerScope Sep 10, 2024
@roxblnfk roxblnfk deleted the run-scope-recursion-fix branch September 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant