Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spiral/queue] Added passing headers to the job handler in SyncDriver #1107

Merged
merged 1 commit into from
May 8, 2024
Merged

[spiral/queue] Added passing headers to the job handler in SyncDriver #1107

merged 1 commit into from
May 8, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented May 8, 2024

Q A
Bugfix? ✔️
Breaks BC? ❌
New feature? ❌

In the Queue component, there is an Spiral\Queue\ExtendedOptionsInterface interface that allows the use headers. The base implementation Spiral\Queue\Options implements this interface. It would be good to pass headers to the job handler.

@msmakouz msmakouz requested review from butschster and roxblnfk May 8, 2024 13:02
@msmakouz msmakouz self-assigned this May 8, 2024
@roxblnfk roxblnfk merged commit 02213d3 into master May 8, 2024
11 of 12 checks passed
@roxblnfk roxblnfk deleted the bugfix/headers-in-sync-driver branch May 8, 2024 16:23
roxblnfk pushed a commit that referenced this pull request May 15, 2024
@msmakouz @roxblnfk
Add headers to SyncDriver (#1107)
d7bf3da
@butschster butschster added this to the 3.13 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

@butschster butschster Awaiting requested review from butschster

Assignees

@msmakouz msmakouz

Labels
Bug Component: Queue
Projects
Spiral framework
Status: Done
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
3 participants
@msmakouz @roxblnfk @butschster