Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor interceptors target #1106

Merged
merged 6 commits into from
May 8, 2024
Merged

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented May 7, 2024

Added more static factory methods in Target
TargetInteface:

  • added getObject() method
  • removed withReflection() method

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (db49785) to head (ad847fd).
Report is 57 commits behind head on feature/scopes.

❗ Current head ad847fd differs from pull request most recent head 703275a. Consider uploading reports for the commit 703275a to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature/scopes    #1106      +/-   ##
====================================================
+ Coverage             89.77%   89.79%   +0.02%     
- Complexity             6381     6473      +92     
====================================================
  Files                   836      851      +15     
  Lines                 18085    18377     +292     
====================================================
+ Hits                  16235    16502     +267     
- Misses                 1850     1875      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit e6f66b2 into feature/scopes May 8, 2024
10 of 11 checks passed
@roxblnfk roxblnfk deleted the refactor-interceptors-target branch May 8, 2024 17:08
@butschster butschster added this to the 3.14 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants