Console scopes #1085
Merged
Console scopes #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
butschster
commented
Feb 21, 2024
butschster
commented
| Q | A |
|---|---|
| Bugfix? | ✔️ |
| Breaks BC? | ✔️ |
| New feature? | ✔️ |
| Issues | #1074 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/scopes #1085 +/- ##
====================================================
+ Coverage 89.54% 89.63% +0.09%
- Complexity 6350 6363 +13
====================================================
Files 829 832 +3
Lines 17926 17976 +50
====================================================
+ Hits 16052 16113 +61
+ Misses 1874 1863 -11 ☔ View full report in Codecov by Sentry. |
msmakouz
approved these changes
Feb 21, 2024
| @@ -103,20 +119,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| } | |||
| } | |||
|
|
|||
| protected function buildCore(): CoreInterface | |||
There was a problem hiding this comment.
This method is protected, it may not be safe to remove it.
roxblnfk
reviewed
Mar 11, 2024
roxblnfk
reviewed
Mar 11, 2024
| ) { | ||
| } | ||
|
|
||
| public function make(array $interceptors, ?EventDispatcherInterface $eventDispatcher = null): CoreInterface |
There was a problem hiding this comment.
Add $interceptors php doc with type
roxblnfk
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.