Merge pull request #471 from samsonasik/add-rector-for-qa

[Rector] Start Add Rector for QA

.github/workflows/main.yml

@@ -56,7 +56,7 @@ jobs:
         run: composer require --dev roave/security-advisories:dev-latest
 
   static-analysis:
-    name: Psalm
+    name: Psalm and Rector
     runs-on: ${{ matrix.os }}
 
     strategy:
@@ -100,7 +100,9 @@ jobs:
 
       # Execution
       - name: Static Analysis
-        run: vendor/bin/psalm --no-cache
+        run: |
+          vendor/bin/psalm --no-cache
+          vendor/bin/rector --dry-run
 
 
   coding-standards:

composer.json

@@ -134,6 +134,7 @@
         "mockery/mockery": "^1.3",
         "phpunit/phpunit": "^8.5|^9.0",
         "ramsey/uuid": "^3.9",
+        "rector/rector": "0.12.3",
         "spiral/broadcast": "^2.0",
         "spiral/broadcast-ws": "^1.0",
         "spiral/code-style": "^1.0",

rector.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Core\Configuration\Option;
+use Rector\Php71\Rector\FuncCall\CountOnNullRector;
+use Rector\Set\ValueObject\LevelSetList;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $parameters = $containerConfigurator->parameters();
+    $parameters->set(Option::PATHS, [
+        __DIR__ . '/src/*/src',
+    ]);
+
+    $parameters->set(Option::SKIP, [
+        CountOnNullRector::class,
+    ]);
+
+    $containerConfigurator->import(LevelSetList::UP_TO_PHP_72);
+};

src/Console/src/Command.php

@@ -70,7 +70,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $resolver = $this->container->get(ResolverInterface::class);
 
         try {
-            list($this->input, $this->output) = [$input, $output];
+            [$this->input, $this->output] = [$input, $output];
 
             //Executing perform method with method injection
             return (int)$reflection->invokeArgs($this, $resolver->resolveArguments(

src/Csrf/src/Middleware/CsrfMiddleware.php

@@ -46,6 +46,7 @@ public function __construct(CsrfConfig $config)
      */
     public function process(Request $request, RequestHandlerInterface $handler): Response
     {
+        $cookie = null;
         if (isset($request->getCookieParams()[$this->config->getCookie()])) {
             $token = $request->getCookieParams()[$this->config->getCookie()];
         } else {

src/Stempler/src/Lexer/Grammar/Dynamic/DeclareGrammar.php

@@ -40,6 +40,7 @@ final class DeclareGrammar implements GrammarInterface
      */
     public function parse(Buffer $src): \Generator
     {
+        $quoted = [];
         while ($n = $src->next()) {
             switch ($n->char) {
                 case '"':

src/Streams/src/StreamWrapper.php

@@ -173,7 +173,7 @@ public static function register()
             return;
         }
 
-        stream_wrapper_register('spiral', __CLASS__);
+        stream_wrapper_register('spiral', self::class);
 
         self::$registered = true;
     }

src/Tokenizer/src/Reflection/ReflectionFile.php

@@ -255,7 +255,7 @@ public function exportSchema(): array
      */
     protected function importSchema(array $cache)
     {
-        list($this->hasIncludes, $this->declarations, $this->functions, $this->namespaces) = $cache;
+        [$this->hasIncludes, $this->declarations, $this->functions, $this->namespaces] = $cache;
     }
 
     /**
@@ -599,7 +599,7 @@ private function registerInvocation(
         //Nested invocations
         $this->locateInvocations($arguments, $invocationLevel + 1);
 
-        list($class, $operator, $name) = $this->fetchContext($invocationID, $argumentsID);
+        [$class, $operator, $name] = $this->fetchContext($invocationID, $argumentsID);
 
         if (!empty($operator) && empty($class)) {
             //Non detectable
@@ -639,7 +639,7 @@ private function fetchContext(int $invocationTID, int $argumentsTID): array
         }
 
         if (!empty($operator)) {
-            list($class, $name) = explode($operator, $name);
+            [$class, $name] = explode($operator, $name);
 
             //We now have to clarify class name
             if (in_array($class, ['self', 'static', '$this'])) {

src/Views/src/Loader/PathParser.php

@@ -83,7 +83,7 @@ public function parse(string $path): ?ViewPath
         }
 
         if (strpos($filename, LoaderInterface::NS_SEPARATOR) !== false) {
-            list($namespace, $filename) = explode(LoaderInterface::NS_SEPARATOR, $filename);
+            [$namespace, $filename] = explode(LoaderInterface::NS_SEPARATOR, $filename);
         }
 
         //Twig like namespaces