[Performance] Get weight sum along with bills to scale #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review and test. I feel like I did some SQLAlchemy magic without fully understanding what I did. But normally, all bills are here with much less queries. |
|
I integrated it on my own instance (Intel Atom D2550), and I dropped from 6,2s to 1,5s page loading in a budget with 197 bills. |
zorun
requested changes
Nov 27, 2021
|
Thanks for the review. Now I see that most of the time is template generation which is clearly less trivial. |
almet
reviewed
Nov 28, 2021
Closed
otherwise, we need to get the weight sum for each displayed bill. Here, we are much more scalable
And also, make it static, since it doesn't rely on instance.
Glandos
force-pushed
the
performance_pay_each
branch
from
af34a23 to
ba4d65d
Compare
|
Hi @Glandos , is there anything blocking this PR? I think it's good to go, no need to fix all performance issues (e.g. templates are another story entirely) |
|
For some reason Github still says that I requested some changes, but I can't find anything related to that. |
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
…t#949) * get weight sum along with bills to scale otherwise, we need to get the weight sum for each displayed bill. Here, we are much more scalable * add test * format * remove unused import * oops, restore pagination to 100 * add comments * format * rename method to make it clearer And also, make it static, since it doesn't rely on instance. * improve comments and naming * improve naming * missing article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we need to get the weight sum for each displayed bill.
Here, we are much more scalable.
With a pagination of 500, we previously had 507 queries if bill currencies were project's default, and nearly the double if not.
Now, we are down to 7.
On my Ryzen 4750G, Flask-debug toolbar profiler told me that displaying 500 out of 1000 bills drop from 2200ms to less than 1000ms.
More performance are expected in other PR.
Finally fixes #159 by continuing #161