This repository has been archived by the owner on Jul 10, 2021. It is now read-only.
chore(docs): Fix misnamed property listed in orca sql configuration #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
suggested changes
Jun 29, 2020
| @@ -64,7 +64,8 @@ sql: | |||
| jdbcUrl: jdbc:mysql://localhost:3306/orca | |||
| user: orca_service | |||
| password: hunter2 | |||
| connectionTimeout: 5000 | |||
| connectionTimeoutMs: 5000 | |||
| maxLifetimeMs: 30000 | |||
| maxLifetime: 30000 | |||
There was a problem hiding this comment.
Looks like you're missing the removal of maxLifetime.
|
Looks great after the comment is fixed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through some recent database troubleshooting, it came to my attention that the property
connectionTimeouton this page should actually beconnectionTimeoutMs.Using just
connectionTimeoutdoes not work which is only noticable if you are trying to increase the timeout because you are hitting it and realize that adjusting this value doesn't do anything. Correcting this in case anyone else runs into similar scaling issues and needs to be able to adjust this value.Property names are taken from https://github.com/spinnaker/kork/blob/master/kork-sql/src/main/kotlin/com/netflix/spinnaker/kork/sql/config/ConnectionPoolProperties.kt
It's also correct on the page https://github.com/spinnaker/orca/blob/7c4d3ceece4063dc62e46913b62da67dfddd452b/orca-peering/README.md#operating-notes but somehow it was overlooked here.