This repository has been archived by the owner on Jul 10, 2021. It is now read-only.
chore(authz/ldap): Remove self-link #1727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorbin
reviewed
Mar 2, 2020
There was a problem hiding this comment.
@kowshikRoy Thanks for the PR. Good catch!
I wonder if we should just delete this "next steps" section entirely. I mean, reading the overview covering a topic of which we're already into the details doesn't sounds like a next step, IMO.
@brian-armory , what say ye?
|
@dorbin that makes sense to me |
|
@kowshikRoy , you want to go ahead with that? |
|
Thanks @kowshikRoy for doing this. I'll go ahead and close this PR and merge the other one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.