fix(artifacts): Consider artifacts from stages when triggering from a pipeline stage #4568
Conversation
… pipeline stage Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
sergio-quintero
force-pushed
the
fix-expected-artifacts-pipeline-stage
branch
from
fbcede6 to
d5611bf
Compare
| def requiredArtifactIds = pipelineConfig.get("stages", []).collectMany { stage -> | ||
| def artifactIds = [] | ||
|
|
||
| //DeployManifestStage in ResolveDeploySourceManifestTask using ManifestEvaluator.getManifestArtifact |
There was a problem hiding this comment.
| //DeployManifestStage in ResolveDeploySourceManifestTask using ManifestEvaluator.getManifestArtifact | |
| // DeployManifestStage in ResolveDeploySourceManifestTask using ManifestEvaluator.getManifestArtifact |
nit
| // BakeManifestStage in CreateBakeManifestTask using BakeManifestContext for Kustomize | ||
| artifactIds += stage.inputArtifact?.id ?: [] | ||
|
|
||
| // BakeManifestStage in CreateBakeManifestTask using BakeManifestContext for Helm |
There was a problem hiding this comment.
Are these comments accurate? What I mean is I understand that Helm bakes with inputArtifacts but other stages like BakeCloudFoundry also utilize this?
Can we make this more generic and say something more like
// Some bake manifest stages may populate the inputArtifacts array. So we need to look to for those ids as well
And we may be able to get rid of the other comments as they seem to be very specific but don't capture the whole picture
There was a problem hiding this comment.
Maybe even explain why we are looking for these ids as opposed to the expected artifact. Would be good to just document here saying we dont know how consuming pipelines will utilize artifacts from the parent pipeline, so we rely on any input artifact as opposed to the expected artifact
| // in ResolveDeploySourceManifestTask using ManifestEvaluator.getRequiredArtifacts | ||
| def requiredArtifactIds = pipelineConfig.get("stages", []).collectMany { | ||
| it.requiredArtifactIds ?: [] | ||
| def requiredArtifactIds = pipelineConfig.get("stages", []).collectMany { stage -> |
There was a problem hiding this comment.
Do we need this variable? Can't we just use expectedArtifactIds here?
|
Closing this PR because we found more stages with different field names that were not considered in this PR. Adding a list of fields in We'll send a new PR with a better fix for this issue. |
Follow up to #4489
Triggering a pipeline from Pipeline A using the pipeline stage where Pipeline B uses BakeManifestStage or DeployManifestStage which rely on expectedArtifacts is broken. ArtifactUtils is filtering the expectedArtifacts needed in stages.
In 1.28, you were able to define expectedArtifacts in Pipeline B, and when you triggered from Pipeline A, Pipeline B was able to resolve the artifacts from Pipeline A. Passing artifacts between pipelines