chore(dependency): add explicit dependency of jaxb-api while upgrading spring boot 2.6.x #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g spring boot 2.6.x
While upgrading spring boot 2.6.15, encounter below errors in igor-monitor-travis module during build:
```
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Build.java:26: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Build.java:38: error: cannot find symbol
@XmlRootElement(name = "builds")
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Branch.java:22: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Branch.java:30: error: cannot find symbol
@XmlRootElement(name = "branch")
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Commit.java:26: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Commit.java:34: error: cannot find symbol
@XmlRootElement(name = "commit")
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Repository.java:21: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Repository.java:26: error: cannot find symbol
@XmlRootElement(name = "repository")
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/AccessToken.java:22: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/AccessToken.java:27: error: cannot find symbol
@XmlRootElement
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:23: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:29: error: cannot find symbol
@XmlRootElement
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Build.java:27: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Build.java:33: error: cannot find symbol
@XmlRootElement(name = "builds")
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:25: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:31: error: cannot find symbol
@XmlRootElement
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Job.java:23: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Job.java:29: error: cannot find symbol
@XmlRootElement(name = "job")
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Commit.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Commit.java:30: error: cannot find symbol
@XmlRootElement(name = "commits")
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/EmptyObject.java:20: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/EmptyObject.java:22: error: cannot find symbol
@XmlRootElement
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:24: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:25: error: package javax.xml.bind.annotation does not exist
import javax.xml.bind.annotation.XmlRootElement;
^
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:31: error: cannot find symbol
@XmlRootElement
^
symbol: class XmlRootElement
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Builds.java:35: error: cannot find symbol
@xmlelement(name = "builds", required = false)
^
symbol: class XmlElement
location: class V3Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:33: error: cannot find symbol
@xmlelement(name = "builds", required = false)
^
symbol: class XmlElement
location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:37: error: cannot find symbol
@xmlelement(name = "jobs", required = false)
^
symbol: class XmlElement
location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/Builds.java:41: error: cannot find symbol
@xmlelement(name = "commits", required = false)
^
symbol: class XmlElement
location: class Builds
/igor/igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/client/model/v3/V3Jobs.java:35: error: cannot find symbol
@xmlelement(name = "jobs", required = false)
^
symbol: class XmlElement
location: class V3Jobs
32 errors
startup failed:
Compilation failed; see the compiler error output for details.
1 error
> Task :igor-monitor-travis:compileGroovy FAILED
```
So, adding explicit dependency of jaxb-api in igor-monitor-travis.gradle. Since jaxb-api is a transitive dependency of [spring boot](https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.6.15/spring-boot-dependencies-2.6.15.pom) both 2.5.x and 2.6.x, pinning the dependency is not required.
dbyron-sf
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading spring boot 2.6.15, encounter below errors in igor-monitor-travis module during build:
To fix these issues, adding explicit dependency of jaxb-api in igor-monitor-travis.gradle. Since jaxb-api is a transitive dependency of spring boot both 2.5.x and 2.6.x, pinning the dependency is not required.