fix(web): add Retrofit2SyncCall.execute to BakeService #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to pave the way for more testing
and how it's not using RoscoService / retrofit2 properly
since (as of spinnaker#1866) RoscoService uses retrofit2.
jasonmcintosh
approved these changes
Feb 27, 2025
|
@Mergifyio backport release-1.37.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* refactor(web): use constructor injection in BakeService to pave the way for more testing * test(web): demonstrate behavior of BakeService and how it's not using RoscoService / retrofit2 properly * fix(web): add Retrofit2SyncCall.execute to BakeService since (as of #1866) RoscoService uses retrofit2. (cherry picked from commit d3dc67d)
mergify bot
added a commit
that referenced
this pull request
Feb 28, 2025
* refactor(web): use constructor injection in BakeService to pave the way for more testing * test(web): demonstrate behavior of BakeService and how it's not using RoscoService / retrofit2 properly * fix(web): add Retrofit2SyncCall.execute to BakeService since (as of #1866) RoscoService uses retrofit2. (cherry picked from commit d3dc67d) Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since (as of #1866) RoscoService uses retrofit2.