fix(front50-gcs): Fix ObjectType filenames for GCS Front50 persistent store (backport #1493) #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By fixing the GCS to SQL migration in this PR and removing the hardcoded "specification.json" from the GCSStorageService i cause an issue with all ObjectTypes except the Application and ApplicationPermission.
More specifically the offending change is this one which had an effect in all the other ObjectTypes in GCS to get/store the filenames defined in the ObjectType and not the previously used
specification.jsonfor GCS.Fixes issue spinnaker/spinnaker#6970
This is an automatic backport of pull request #1493 done by [Mergify](https://mergify.com).