Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws): CleanupAlarmsAgent with an optional user-defined name pattern #6317

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat(aws): CleanupAlarmsAgent with an optional user-defined name pattern #6317

merged 1 commit into from
Dec 13, 2024

Conversation

christosarvanitis
Copy link
Member

Users might defined a custom name for the scaling policies and alarms names that dont match the strict namePattern of the AlarmsCleanUp agent.
Especially for custom alarms when a scaling policy is deleted the alarms are not cascade deleted leading to stale cache in the cats_v1_alarms table.

This PR allows the user to define their own AlarmsNamePattern for the AlarmsCleanupAgent

jasonmcintosh
jasonmcintosh approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should be a feature. yes it's config flagged

@christosarvanitis christosarvanitis changed the title fix(aws): CleanupAlarmsAgent with an optional user-defined name pattern feat(aws): CleanupAlarmsAgent with an optional user-defined name pattern Dec 13, 2024
@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for a merge label Dec 13, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Dec 13, 2024
@mergify mergify bot merged commit 53f11a8 into spinnaker:master Dec 13, 2024
23 checks passed
@jasonmcintosh
Copy link
Member

@Mergifyio backport release-1.35.x release-1.36.x release-1.34.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

backport release-1.35.x release-1.36.x release-1.34.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@christosarvanitis @mergify
feat(aws): CleanupAlarmsAgent with an optional user-defined name patt…
847f34d 
…ern (#6317)

(cherry picked from commit 53f11a8)
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@christosarvanitis @mergify
feat(aws): CleanupAlarmsAgent with an optional user-defined name patt…
5054a69 
…ern (#6317)

(cherry picked from commit 53f11a8)
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@christosarvanitis @mergify
feat(aws): CleanupAlarmsAgent with an optional user-defined name patt…
06a2bdb 
…ern (#6317)

(cherry picked from commit 53f11a8)
This was referenced Dec 13, 2024
Merged
Merged
Merged
christosarvanitis added a commit to armory-io/clouddriver that referenced this pull request Dec 13, 2024
@christosarvanitis
feat(aws): CleanupAlarmsAgent with an optional user-defined name patt…
977b969 
…ern (spinnaker#6317)
mergify bot added a commit that referenced this pull request Dec 13, 2024
@mergify @christosarvanitis
feat(aws): CleanupAlarmsAgent with an optional user-defined name patt…
c2ba7f0 
…ern (#6317) (#6320)

(cherry picked from commit 53f11a8)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Dec 13, 2024
@mergify @christosarvanitis
feat(aws): CleanupAlarmsAgent with an optional user-defined name patt…
966f4e8 
…ern (#6317) (#6319)

(cherry picked from commit 53f11a8)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Dec 13, 2024
@mergify @christosarvanitis
feat(aws): CleanupAlarmsAgent with an optional user-defined name patt…
fb1850b 
…ern (#6317) (#6318)

(cherry picked from commit 53f11a8)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
@christosarvanitis christosarvanitis mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

@jeyrschabu jeyrschabu Awaiting requested review from jeyrschabu jeyrschabu is a code owner

@ajordens ajordens Awaiting requested review from ajordens ajordens is a code owner

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.37
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christosarvanitis @jasonmcintosh @spinnakerbot