Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom StarlingMonkey runtime builds #342

Merged
merged 1 commit into from
Feb 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bin/j2w.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ const args = yargs(hideBin(process.argv))
alias: 'd',
describe: 'Path to wit file or folder',
})
.option('runtime-path', {
alias: 'r',
describe: 'Path to a custom runtime wasm file',
})
.option('output', {
alias: 'o',
describe: 'Path to the output file',
Expand Down Expand Up @@ -115,6 +119,7 @@ async function saveBuildData(buildDataPath, checksum, version) {
const { component } = await componentize(precompiledSource, {
sourceName: basename(src),
witPath,
engine: args.runtimePath,
worldName: args.triggerType,
disableFeatures: [],
enableFeatures: ["http"],
Expand Down
5 changes: 3 additions & 2 deletions test/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ echo "built the test app successfully"
# Start the spin app in the background
echo "Starting Spin app"
spin up &
SPIN_PID=$!

# wait for app to be up and running
echo "Waiting for Spin app to be ready"
Expand All @@ -30,10 +31,10 @@ echo "\n\nTest completed"

# kill the spin app
echo "Stopping Spin"
killall spin
kill -9 $SPIN_PID


if [ "$isFailed" = true ] ; then
echo "Some tests failed"
exit 1
fi
fi