sdsv3: Don't log error when connection closes #5835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
amartinezfayo
approved these changes
Feb 3, 2025
sorindumitru
force-pushed
the
suppress-error
branch
from
eafeb69 to
936942f
Compare
If we receive a nil error on the errch it means that the connection has been closed cleanly. We shouldn't log an error in that case. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
suppress-error
branch
from
936942f to
2bfec7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive a nil error on the
errchit means that the connection has been closed cleanly. We shouldn't log an error in that case.