cli support for registration entry "federates with" list #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
There was a problem hiding this comment.
Looks great!
We should update doc/spire_server.md with the new CLI commands / options.
I noticed that the registration handler does not properly propagate errors. E.g.: when trying to create an entry using the -federatesWith argument specifying a SPIFFE ID of a TD that cannot be found, I get:
rpc error: code = Unknown desc = Error trying to create entry which does not provide error details (should include the unable to find federated bundle... error).
This is a pre-existing issue but it would be great if we can address it. It seems that we may just need to return err here: https://github.com/spiffe/spire/blob/master/pkg/server/endpoints/registration/handler.go#L61
We can address that separately.
Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying trust domain SPIFFE IDs that a registration entry federates with.