HTTP CONNECT proxy support #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
evan2645
previously approved these changes
Aug 28, 2018
azdagron
force-pushed
the
http-proxy-support
branch
2 times, most recently
from
a432912 to
bfbb66e
Compare
martincapello
previously approved these changes
Aug 28, 2018
SPIRE uses a custom dialer in order to get better diagnostics on handshake failures. Unfortunately the custom dialer does not support HTTP CONNECT proxies. This commit cribs the proxy support code from the gRPC codebase and incorporates it into the custom dialer. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
force-pushed
the
http-proxy-support
branch
from
bfbb66e to
f10f7ad
Compare
martincapello
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIRE uses a custom dialer in order to get better diagnostics on
handshake failures. Unfortunately the custom dialer does not support
HTTP CONNECT proxies.
This commit cribs the proxy support code from the gRPC codebase and
incorporates it into the custom dialer.