spire-agent: limit JWT-SVID cache size #5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
rturner3
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Overall looks good to me @sorindumitru, just had a few minor comments
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
jwt-svid-cache
branch
from
e6be20b to
5e733d6
Compare
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
jwt-svid-cache
branch
from
5e733d6 to
039e25e
Compare
rturner3
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
spire-agent JWT-SVID cache
Description of change
This PR makes the maximum size of the JWT-SVID cache in spire-agent configurable. This avoid the cache becoming too large and using too much memory. When the cache becomes too big, the least recently used JWT-SVID is evicted.
There's more improvements that can be made here. We could also periodically try to evict expired tokens, since tokens can have different TTLs. Opening this for now to see if that's a desired behaviour.
Which issue this PR fixes
fixes #4891