Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic documentation about the template engine #5625

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

kfox1111
Copy link
Contributor

@kfox1111 kfox1111 commented Nov 2, 2024

No description provided.

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few small comments.

Comment on lines 9 to 11
In addition to the built in functions as described [here](https://pkg.go.dev/text/template#hdr-Functions).

We also include a set of functions from the SPRIG library.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two sentences feel like they belong together, separated by comma?

doc/template_engine.md Outdated Show resolved Hide resolved
@azdagron azdagron self-assigned this Nov 5, 2024
Co-authored-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
doc/template_engine.md Outdated Show resolved Hide resolved
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
@MarcosDY MarcosDY merged commit a5a4269 into spiffe:main Nov 19, 2024
34 checks passed
@MarcosDY MarcosDY added this to the 1.11.1 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants