Document some missing configuration items #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
sorindumitru
force-pushed
the
doc-updates
branch
from
b935389 to
3cd2db5
Compare
doc/spire_server.md
Outdated
| @@ -82,6 +82,7 @@ This may be useful for templating configuration files, for example across differ | |||
| | `ratelimit` | Rate limiting configurations, usually used when the server is behind a load balancer (see below) | | | |||
| | `socket_path` | Path to bind the SPIRE Server API socket to (Unix only) | /tmp/spire-server/private/api.sock | | |||
| | `trust_domain` | The trust domain that this server belongs to (should be no more than 255 characters) | | | |||
| | `use_legacy_downstream_x509_ca_ttl` | Use the downstream spire-server registration entry TTL as the downstream CA TTL. This will be deprecated in SPIRE 1.12.0 | true | | |||
There was a problem hiding this comment.
This will be deprecated in SPIRE 1.12.0
Since this is already deprecated, I would change that to say:
This is deprecated and will be removed in a future version.
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
doc-updates
branch
from
5ed1777 to
8aead66
Compare
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
doc-updates
branch
from
8aead66 to
139daaa
Compare
amartinezfayo
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes
fixes #5382