Mark LRU Cache disablement and sizing as deprecated #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
amoore877
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
Signed-off-by: amoore877 <andrew.s.moore@uber.com>
MarcosDY
approved these changes
May 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Size and disablement configuration of LRU cache
Description of change
Mark these features as disabled per plan in #4224, to be released in 1.10.
In 1.11 the configurations will be removed entirely along with the non-LRU cache code.
Code block needed to be moved in order to have access to the constructed logger.
A separate PR might consider moving logger construction to as early as possible.
Which issue this PR fixes
Progresses, but does not solve, #4224