Drain handlers when unloading built-in plugin #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the built-in plugin implementation to wait for all RPC handlers to drain when unloading the plugin. This is not only important for graceful shut down of SPIRE but also allows plugin tests to deterministically assert properties after invoking streaming RPCs. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
MarcosDY
previously approved these changes
Jan 19, 2024
Signed-off-by: Andrew Harding <azdagron@gmail.com>
MarcosDY
approved these changes
Jan 19, 2024
faisal-memon
pushed a commit
to faisal-memon/spire
that referenced
this pull request
Feb 7, 2024
* Drain handlers when unloading built-in plugin This change updates the built-in plugin implementation to wait for all RPC handlers to drain when unloading the plugin. This is not only important for graceful shut down of SPIRE but also allows plugin tests to deterministically assert properties after invoking streaming RPCs. Signed-off-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>
sriyer
pushed a commit
to spire-vault/spire
that referenced
this pull request
Feb 23, 2024
* Drain handlers when unloading built-in plugin This change updates the built-in plugin implementation to wait for all RPC handlers to drain when unloading the plugin. This is not only important for graceful shut down of SPIRE but also allows plugin tests to deterministically assert properties after invoking streaming RPCs. Signed-off-by: Andrew Harding <azdagron@gmail.com>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
* Drain handlers when unloading built-in plugin This change updates the built-in plugin implementation to wait for all RPC handlers to drain when unloading the plugin. This is not only important for graceful shut down of SPIRE but also allows plugin tests to deterministically assert properties after invoking streaming RPCs. Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the built-in plugin implementation to wait for all RPC handlers to drain when unloading the plugin.
This is not only important for graceful shut down of SPIRE but also allows plugin tests to deterministically assert properties after invoking streaming RPCs.