Populate cache from events #4562

faisal-memon · 2023-10-15T06:23:13Z

Pull Request check list

Commit conforms to CONTRIBUTING.md?
Proper tests/regressions included?
Documentation updated?

Affected functionality

SPIRE Server caching layer

Description of change

Creates a new entry fetcher that is used when the feature flag is set
New entry fetcher populates new authorized entry cache from events for agents and entries

what's missing:

Unit tests
Checking events on start up

Which issue this PR fixes

fixes #4498

pkg/server/endpoints/authorized_entry_fetcher.go

azdagron · 2023-10-22T17:19:24Z

pkg/server/endpoints/authorized_entry_fetcher.go

+
+		if commonEntry == nil {
+			a.cache.RemoveEntry(entryID)
+			a.lastEventID++


Hmm. Is the event ID in the response? It seems like this loop would be more robust if it was instead of blindly incrementing.

We get all the events ids back from the database but only provide the first event id in the api response. We can adjust to not blindly increment and set the last event id to the one in the response per iteration

this change is in

pkg/server/endpoints/authorized_entry_fetcher.go

azdagron

It's getting there. Are there tests incoming? Looks like there are some lint failures too.

pkg/server/endpoints/authorized_entry_fetcher.go

faisal-memon · 2023-11-16T19:45:47Z

It's getting there. Are there tests incoming? Looks like there are some lint failures too.

They are, just heads down on some other tasks right now.

azdagron

Thanks for the updates @faisal-memon! Looks like DCO is broken. Otherwise, is this ready? If so, can you take it out of draft?

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Fix casing Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* Bump SPIRE to version 1.8.2 Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* Agent manager retries sync during init Agent manager retries every 5 seconds for a total of 1 minute to fetch SVIDs from the server during initalization. Signed-off-by: Nico Weisenauer <nico.weisenauer@sap.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the azure-sdk group with 2 updates: [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) and [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go). Updates `github.com/Azure/azure-sdk-for-go/sdk/azcore` from 1.7.2 to 1.8.0 - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.7.2...sdk/azcore/v1.8.0) Updates `github.com/Azure/azure-sdk-for-go/sdk/azidentity` from 1.3.1 to 1.4.0 - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.3.1...sdk/azcore/v1.4.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore dependency-type: direct:production update-type: version-update:semver-minor dependency-group: azure-sdk - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity dependency-type: direct:production update-type: version-update:semver-minor dependency-group: azure-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0. - [Commits](golang/net@v0.15.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the aws-sdk group with 1 update: [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2). - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.123.0...service/ec2/v1.124.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/sigstore/sigstore/releases) - [Commits](sigstore/sigstore@v1.7.2...v1.7.3) --- updated-dependencies: - dependency-name: github.com/sigstore/sigstore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.145.0 to 0.146.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.145.0...v0.146.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/sigstore/rekor](https://github.com/sigstore/rekor) from 1.3.0 to 1.3.2. - [Release notes](https://github.com/sigstore/rekor/releases) - [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md) - [Commits](sigstore/rekor@v1.3.0...v1.3.2) --- updated-dependencies: - dependency-name: github.com/sigstore/rekor dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/uber-go/tally/v4](https://github.com/uber-go/tally) from 4.1.7 to 4.1.10. - [Release notes](https://github.com/uber-go/tally/releases) - [Commits](uber-go/tally@v4.1.7...v4.1.10) --- updated-dependencies: - dependency-name: github.com/uber-go/tally/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.10.0 to 0.10.2. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG-v0.md) - [Commits](hashicorp/vault@v0.10.0...v0.10.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.146.0 to 0.147.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.146.0...v0.147.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

) Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.56.0 to 0.57.0. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v0.56.0...v0.57.0) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/opa dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the aws-sdk group with 1 update: [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2). - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.124.0...service/ec2/v1.125.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.7.3 to 1.7.4. - [Release notes](https://github.com/sigstore/sigstore/releases) - [Commits](sigstore/sigstore@v1.7.3...v1.7.4) --- updated-dependencies: - dependency-name: github.com/sigstore/sigstore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

@mnp

…tstrap can be set (spiffe#4532) @mnp reported in issue 4530 that it was possible to set trust_bundle_url and insecure_bootstrap in the Agent configuration. There was a test for this case. However, the test was just checking if there was an error. There was an error but not the expected one. This commit also adds expectErrorContains to the test case struct so tests can check the expected error message. Also, more tests added. Signed-off-by: Matteus Silva <silvamatteus@lsd.ufcg.edu.br> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Currently these are hard coded to spire_server/spire_agent. I'd like to be able to differentiate between different instances (e.g. for different trust domains) when the metrics end up being aggregated in a single place. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the aws-sdk group with 2 updates: [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2). Updates `github.com/aws/aws-sdk-go-v2/service/ec2` from 1.133.0 to 1.137.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.133.0...service/ec2/v1.137.1) Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.42.0 to 1.44.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.42.0...service/s3/v1.44.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/s3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Signed-off-by: Ryan Turner <turner@uber.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the azure-sdk group with 1 update: [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources](https://github.com/Azure/azure-sdk-for-go). - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.1.1...v1.2) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources dependency-type: direct:production update-type: version-update:semver-minor dependency-group: azure-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the aws-sdk group with 2 updates: [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/service/secretsmanager](https://github.com/aws/aws-sdk-go-v2). Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.44.0 to 1.45.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.44.0...service/s3/v1.45.0) Updates `github.com/aws/aws-sdk-go-v2/service/secretsmanager` from 1.23.0 to 1.24.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.23.0...config/v1.24.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/s3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/secretsmanager dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0. - [Commits](golang/crypto@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.18.0 to 0.19.0. - [Commits](golang/net@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [golang.org/x/time](https://github.com/golang/time) from 0.4.0 to 0.5.0. - [Commits](golang/time@v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.151.0 to 0.152.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.151.0...v0.152.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@7bbfa03...01bc870) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bumps the aws-sdk group with 7 updates: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go-v2/service/acmpca](https://github.com/aws/aws-sdk-go-v2) | `1.24.0` | `1.25.1` | | [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) | `1.137.1` | `1.138.1` | | [github.com/aws/aws-sdk-go-v2/service/iam](https://github.com/aws/aws-sdk-go-v2) | `1.27.0` | `1.28.1` | | [github.com/aws/aws-sdk-go-v2/service/kms](https://github.com/aws/aws-sdk-go-v2) | `1.26.0` | `1.27.1` | | [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) | `1.45.0` | `1.47.1` | | [github.com/aws/aws-sdk-go-v2/service/secretsmanager](https://github.com/aws/aws-sdk-go-v2) | `1.24.0` | `1.25.1` | | [github.com/aws/aws-sdk-go-v2/service/sts](https://github.com/aws/aws-sdk-go-v2) | `1.25.1` | `1.26.1` | Updates `github.com/aws/aws-sdk-go-v2/service/acmpca` from 1.24.0 to 1.25.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.24.0...config/v1.25.1) Updates `github.com/aws/aws-sdk-go-v2/service/ec2` from 1.137.1 to 1.138.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.137.1...service/ec2/v1.138.1) Updates `github.com/aws/aws-sdk-go-v2/service/iam` from 1.27.0 to 1.28.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/ecs/v1.28.1/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.27.0...service/ecs/v1.28.1) Updates `github.com/aws/aws-sdk-go-v2/service/kms` from 1.26.0 to 1.27.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.26.0...service/s3/v1.27.1) Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.45.0 to 1.47.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.45.0...service/s3/v1.47.1) Updates `github.com/aws/aws-sdk-go-v2/service/secretsmanager` from 1.24.0 to 1.25.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.24.0...config/v1.25.1) Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.25.1 to 1.26.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.25.1...service/s3/v1.26.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/acmpca dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/iam dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/kms dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/s3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/secretsmanager dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk - dependency-name: github.com/aws/aws-sdk-go-v2/service/sts dependency-type: direct:production update-type: version-update:semver-minor dependency-group: aws-sdk ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

* Make agent crash when getting an unknown authority error when sync entries with spire server Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

) Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.58.0 to 0.59.0. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v0.58.0...v0.59.0) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/opa dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

…iffe#4705) Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.16.1 to 0.17.0. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml) - [Commits](google/go-containerregistry@v0.16.1...v0.17.0) --- updated-dependencies: - dependency-name: github.com/google/go-containerregistry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

faisal-memon · 2023-12-02T06:27:51Z

Thanks for the updates @faisal-memon! Looks like DCO is broken. Otherwise, is this ready? If so, can you take it out of draft?

Done.

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

edwbuck · 2023-12-04T22:05:24Z

@faisal-memon This branch is out of date with the base branch. Please bring it up to date, so the review process will move forward smoothly.

faisal-memon · 2023-12-04T22:17:00Z

@faisal-memon This branch is out of date with the base branch. Please bring it up to date, so the review process will move forward smoothly.

Thanks @edwbuck . Its up to date now.

Also noticed this unit test failure, though I dont think its related to this change set: https://github.com/spiffe/spire/actions/runs/7069157455/job/19244555671?pr=4562

azdagron

I think this is ready. Thanks for the hard work, @faisal-memon .

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

azdagron reviewed Oct 22, 2023

View reviewed changes

azdagron added this to the 1.8.4 milestone Oct 24, 2023

amartinezfayo modified the milestones: 1.8.4, 1.8.5 Nov 8, 2023

azdagron reviewed Nov 16, 2023

View reviewed changes

pkg/server/endpoints/authorized_entry_fetcher.go Outdated Show resolved Hide resolved

pkg/server/endpoints/authorized_entry_fetcher.go Outdated Show resolved Hide resolved

amartinezfayo modified the milestones: 1.8.5, 1.8.6 Nov 16, 2023

azdagron reviewed Dec 1, 2023

View reviewed changes

faisal-memon and others added 21 commits December 1, 2023 22:23

Populate cache from events

01d026f

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Update pkg/server/endpoints/authorized_entry_fetcher.go

69a898a

Fix casing Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bump SPIRE to version 1.8.2 (spiffe#4549)

a9d7366

* Bump SPIRE to version 1.8.2 Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Update to go 1.21.3 (spiffe#4550)

6bf2dd1

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

chore: import packages only once (spiffe#4540)

105995e

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Bump SPIRE to version 1.8.3 (spiffe#4557)

523eb5e

Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

dependabot bot and others added 13 commits December 1, 2023 22:23

Update main branch after v1.8.5 release (spiffe#4687)

668879f

Signed-off-by: Ryan Turner <turner@uber.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Make agent fail when getting unknown authority (spiffe#4617)

9b1f8a2

* Make agent crash when getting an unknown authority error when sync entries with spire server Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>

faisal-memon force-pushed the events-based-cache branch from 5cfea98 to a31e16e Compare December 2, 2023 06:24

Merge branch 'main' into events-based-cache

45b0327

faisal-memon marked this pull request as ready for review December 2, 2023 06:26

faisal-memon requested review from evan2645, amartinezfayo, MarcosDY and rturner3 as code owners December 2, 2023 06:26

De dupe events

06990c3

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

Merge branch 'main' into events-based-cache

0bd292d

azdagron approved these changes Dec 5, 2023

View reviewed changes

azdagron merged commit 5ccf55f into spiffe:main Dec 5, 2023
31 checks passed

azdagron mentioned this pull request Dec 5, 2023

Dynamic authorized entry cache #4498

Closed

7 tasks

rushi47 pushed a commit to rushi47/spire that referenced this pull request Apr 11, 2024

Populate cache from events (spiffe#4562)

7ffd7de

Signed-off-by: Faisal Memon <fymemon@yahoo.com>

faisal-memon deleted the events-based-cache branch July 4, 2024 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Populate cache from events #4562

Populate cache from events #4562

faisal-memon commented Oct 15, 2023

azdagron Oct 22, 2023

faisal-memon Nov 17, 2023

faisal-memon Nov 30, 2023

azdagron left a comment

faisal-memon commented Nov 16, 2023

azdagron left a comment

faisal-memon commented Dec 2, 2023

edwbuck commented Dec 4, 2023

faisal-memon commented Dec 4, 2023

azdagron left a comment

Populate cache from events #4562

Populate cache from events #4562

Conversation

faisal-memon commented Oct 15, 2023

azdagron Oct 22, 2023

Choose a reason for hiding this comment

faisal-memon Nov 17, 2023

Choose a reason for hiding this comment

faisal-memon Nov 30, 2023

Choose a reason for hiding this comment

azdagron left a comment

Choose a reason for hiding this comment

faisal-memon commented Nov 16, 2023

azdagron left a comment

Choose a reason for hiding this comment

faisal-memon commented Dec 2, 2023

edwbuck commented Dec 4, 2023

faisal-memon commented Dec 4, 2023

azdagron left a comment

Choose a reason for hiding this comment