Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value to output format flag description #3713

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

guilhermocc
Copy link
Contributor

@guilhermocc guilhermocc commented Dec 21, 2022

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

  • No functionality affected.
    Description of change
  • Add default value to output format flag description.

Which issue this PR fixes
ongoing work for #1354

Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@amartinezfayo amartinezfayo merged commit db16fec into spiffe:main Dec 21, 2022
@azdagron azdagron added this to the 1.5.4 milestone Dec 23, 2022
divaspathak pushed a commit to divaspathak/spire that referenced this pull request Dec 24, 2022
* Add default value to output format flag description

Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: divaspathak <divaspathak@gmail.com>
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
* Add default value to output format flag description

Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants