Write files on Windows with a specific security descriptor #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
evan2645,
azdagron,
MarcosDY and
rturner3
as code owners
guilhermocc
reviewed
Nov 9, 2022
Comment on lines
+362
to
+373
| s.Require().NoError(diskutil.WritePubliclyReadableFile(fooPKCS1KeyPath, pem.EncodeToMemory(&pem.Block{ | ||
| Type: "RSA PUBLIC KEY", | ||
| Bytes: fooPKCS1Bytes, | ||
| }), 0600)) | ||
| }))) | ||
|
|
||
| fooPKIXKeyPath := filepath.Join(s.dir, "foo-pkix.pem") | ||
| fooPKIXBytes, err := x509.MarshalPKIXPublicKey(s.fooKey.Public()) | ||
| s.Require().NoError(err) | ||
| s.Require().NoError(os.WriteFile(fooPKIXKeyPath, pem.EncodeToMemory(&pem.Block{ | ||
| s.Require().NoError(diskutil.WritePubliclyReadableFile(fooPKIXKeyPath, pem.EncodeToMemory(&pem.Block{ | ||
| Type: "PUBLIC KEY", | ||
| Bytes: fooPKIXBytes, | ||
| }), 0600)) | ||
| }))) |
There was a problem hiding this comment.
@amartinezfayo shouldn't we use WritePrivateFile instead of WritePubliclyReadableFile here?
There was a problem hiding this comment.
I've been back and forth thinking if the calls in the testing code should be replaced. I've just found that this is problematic in the integration tests so I'll go ahead and just use the new functions in the specific places that we need to honor the permissions when running SPIRE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
os.WriteFilefunction is used in SPIRE to write to a file with specific permission bits. This works well in Unix platforms but it doesn't allow to specify a specific security descriptor on Windows.This PR adds two new functions to our
diskutilpackage:WritePrivateFileandWritePubliclyReadableFile. Those functions have os-specific implementations that respect the intended permissions in each platform.Fixes part of #3189.