Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Pod.pod_name should be .Pod.Name in example #3468

Merged
merged 1 commit into from
Sep 30, 2022
Merged

.Pod.pod_name should be .Pod.Name in example #3468

merged 1 commit into from
Sep 30, 2022

Conversation

keeganwitt
Copy link
Contributor

This is just a documentation fix. The example doesn't use the correct variable to reference to pod name.

@keeganwitt keeganwitt force-pushed the identity_template_example_typo branch from 0d3ad56 to 079aecd Compare September 29, 2022 20:14
@keeganwitt
.Pod.pod_name should be .Pod.Name in example
2919823 
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
@keeganwitt keeganwitt force-pushed the identity_template_example_typo branch from 079aecd to 2919823 Compare September 30, 2022 03:23
azdagron
azdagron approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azdagron azdagron added this to the 1.5.0 milestone Sep 30, 2022
@azdagron azdagron merged commit 2b1c38f into spiffe:main Sep 30, 2022
@keeganwitt keeganwitt deleted the identity_template_example_typo branch September 30, 2022 20:57
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
@keeganwitt @stevend-uber
.Pod.pod_name should be .Pod.Name in example (spiffe#3468)
f997b51 
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azdagron azdagron azdagron approved these changes

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@amartinezfayo amartinezfayo Awaiting requested review from amartinezfayo amartinezfayo is a code owner

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

@rturner3 rturner3 Awaiting requested review from rturner3 rturner3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keeganwitt @azdagron