-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic run-time startup tests #70
Comments
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Sep 12, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br>
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Sep 12, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Oct 14, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Oct 17, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com>
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Oct 25, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Nov 21, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Dec 6, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
rodrigolc
added a commit
to rodrigolc/spire
that referenced
this issue
Dec 7, 2022
* refactor: renamed ExperimentalSigstoreConfig to SigstoreConfig Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * docs: fixed comment about AllowedSubjectListEnabled Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: flattened chained if blocks Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: removed explicit default values for sigstore options from k8sConfig object Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved internal sigstore config to new struct, removed bool. tests: fixed tests after refactor, added test for sigstore struct pointer value. Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: moved sigstore instantiation to Plugin.Configure Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: removed sigstoreEnabled flag from error cases Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: removed trailing colon from error message Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * tests: fixed fetch failure test, added log checking Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed a comment on sigstore configs Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * lint: removed unused function Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * fix: fixed nil reference error Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> * refactor: added logger on Configure, for when Sigstore isn't created until after setLogger Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Rodrigo Lopes <rlc2@cesar.org.br> Co-authored-by: Rodrigo Lopes <rlc2@cesar.org.br> Signed-off-by: Willian Alves <wiilliian.alves@gmail.com> Signed-off-by: Matheus Santos <matheusdefariascs@gmail.com>
ajessup
added a commit
to ajessup/spire
that referenced
this issue
Feb 1, 2023
ajessup
pushed a commit
to ajessup/spire
that referenced
this issue
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
some classes of coding errors only some up at runtime, add a quick integration test
The text was updated successfully, but these errors were encountered: