reconciler: don't delete join token based entries #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashankram
force-pushed
the
preserve-join-token
branch
from
d1ea6c8 to
f0531fe
Compare
kfox1111
reviewed
Feb 8, 2024
Updates the reconciler to ignore the deletion of join token based entries since join tokens are created out-of-band and can be used in conjunction with the controller-manager. Resolves spiffe#247 Signed-off-by: Shashank Ram <shashank.ram@solo.io>
shashankram
force-pushed
the
preserve-join-token
branch
from
f0531fe to
bb5e092
Compare
fixed, thanks |
azdagron
reviewed
Feb 13, 2024
Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Shashank Ram <21697719+shashankram@users.noreply.github.com>
azdagron
previously approved these changes
Feb 13, 2024
azdagron
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the reconciler to ignore the deletion of join token based entries since join tokens are created out-of-band and can be used in conjunction with the controller-manager.
Resolves #247