-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FetchJWTSVIDs function for workloadapi and jwtSource #187
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
26401ec
Add FetchJWTSVIDs function for workloadapi and jwtSource
loveyana a6fe639
Merge branch 'main' into add-workloadapi-fetchjwtsvids
loveyana 4071e36
Merge branch 'main' into add-workloadapi-fetchjwtsvids
loveyana 1282ba7
Fix array out of bounds problem
loveyana 4981b23
Merge branch 'main' into add-workloadapi-fetchjwtsvids
azdagron 9e22b55
fix linting
azdagron d23216d
Merge branch 'main' into add-workloadapi-fetchjwtsvids
azdagron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check should move above the for loop and check the length of SVIDs in the response, otherwise, if the response has no SVIDs and
firstOnly
is true, we will panic on line 445.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I directly copied the code of
parseX509SVIDs
and modified it. I didn't notice it here. I thinkparseX509SVIDs
also has this problem, so I modified it at the same time.In addition, I would like to ask about
java-spiffe
, this spiffe/java-spiffe#90 not assigned to reviewer, any idea?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loveyana I'm reviewing it today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, I may need help to look at the HewlettPackard/py-spiffe#105. It seems that the lint in CI on the
py-spiffe
side is wrong, but I passed it locally, and it seems that the previous pr also has the same problem. I hope you can help and review it at the same time