-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid styles): header position and background #610
Conversation
I don't think sticky header is a good idea tho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, I think this is what I was going for originally. Thanks for catching the readme bug too 🙃
I personally found it really annoying to have to scroll all the way up to the top to change colour schemes or search. Maybe we can tighten the spacing up a bit so it's not as tall? |
I would also remove this part. It doesn't let me suggest on unmodified lines I guess. .marketplace-header__left {
position: absolute;
left: 0;
} |
Co-authored-by: Isaac <padspambox@gmail.com>
done |
This didn't cause any issues. It's an issue with global navbar and I don't feel like fixing it in spicetify itself so it's up to developer to fix it. Marketplace has it already fixed with |
You're right yeah. idk why I sent this in the marketplace repo... |
before:
after: