Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): conflict with search page #524

Merged
merged 4 commits into from
Jun 24, 2023
Merged

fix(readme): conflict with search page #524

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f4923b
fix(readme): conflict with search page
kyrie25 Jun 22, 2023
0127cfc
chore: move cleanup function before statement
kyrie25 Jun 22, 2023
58a01c5
test: find container
kyrie25 Jun 22, 2023
080f4fa
fix: return function
kyrie25 Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/ReadmePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,14 @@ class ReadmePage extends React.Component<
const main = document.querySelector("#marketplace-readme")?.closest("main");
if (main) {
const callScrollbar = setInterval(() => {
if (!document.querySelector("#marketplace-readme")) {
clearInterval(callScrollbar);
main.style.removeProperty("overflow-y");
return;
}
// TODO: see if it's possible to use some load event or mutation observer to do this
main.style.overflowY = "visible";
main.style.overflowY = "auto";
if (!document.querySelector(".os-scrollbar-vertical.os-scrollbar-unusable") || !main)
clearInterval(callScrollbar);
}, 1000);
}

Expand Down