Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql-analysis.yml #330

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Create codeql-analysis.yml #330

merged 8 commits into from
Sep 26, 2022

Conversation

CharlieS1103
Copy link
Member

No description provided.

@CharlieS1103 CharlieS1103 marked this pull request as ready for review September 22, 2022 21:35
@CharlieS1103 CharlieS1103 requested a review from a team as a code owner September 22, 2022 21:35
@CharlieS1103 CharlieS1103 requested review from theRealPadster and removed request for a team September 22, 2022 21:35
@CharlieS1103
Copy link
Member Author

@theRealPadster This is probably a good thing to add, seems not of our URL inputs are sanitized which we should probably get on tbh.

@theRealPadster
Copy link
Member

@theRealPadster This is probably a good thing to add, seems not of our URL inputs are sanitized which we should probably get on tbh.

Yep. I fixed the one issue but haven't gotten around to the others. Feel free to give it a try 😉

@CharlieS1103
Copy link
Member Author

@theRealPadster This is probably a good thing to add, seems not of our URL inputs are sanitized which we should probably get on tbh.

Yep. I fixed the one issue but haven't gotten around to the others. Feel free to give it a try 😉

Will do, whenever I find free time lmfao

@theRealPadster
Copy link
Member

@CharlieS1103 Fixed everything except for the the one dealing with your getInvalidCSS function. It seems to think you should change it to use a regex with the g option to ensure it replaces all instances in the string. I'm not really sure what the function does, so I think I'll leave that one to you.

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@CharlieS1103 CharlieS1103 merged commit fcc7ee6 into main Sep 26, 2022
@CharlieS1103 CharlieS1103 deleted the codeql-analysis branch September 26, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants