Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snippet): better lyrics style #316

Merged
merged 2 commits into from
Sep 3, 2022
Merged

feat(snippet): better lyrics style #316

merged 2 commits into from
Sep 3, 2022

Conversation

Tetrax-10
Copy link
Contributor

No description provided.

@Tetrax-10 Tetrax-10 requested a review from a team as a code owner September 3, 2022 04:23
@Tetrax-10 Tetrax-10 requested review from theRealPadster and removed request for a team September 3, 2022 04:23
@theRealPadster
Copy link
Member

theRealPadster commented Sep 3, 2022

@CharlieS1103 Do you know if these classes are/were ever mapped? If we add this, it'll break next time the classes change, like that arrow one.

@CharlieS1103
Copy link
Member

@CharlieS1103 Do you know if these classes are/were ever mapped? If we add this, it'll break next time the classes change, like that arrow one.

Lifes a gamble.

@Tetrax-10
Copy link
Contributor Author

@CharlieS1103 Do you know if these classes are/were ever mapped? If we add this, it'll break next time the classes change, like that arrow one.

If classes change no prob I will regularly check and update every single snippet, themes, extension bro don't worry. I use this in my theme so if some class change I will update it

@kyrie25
Copy link
Member

kyrie25 commented Sep 3, 2022

Do you know if these classes are/were ever mapped? If we add this, it'll break next time the classes change, like that arrow one.

Seems like it has never been, I'll start mapping it from now and we can change the class names there

@kyrie25
Copy link
Member

kyrie25 commented Sep 3, 2022

If classes change no prob I will regularly check and update every single snippet, themes, extension bro don't worry. I use this in my theme so if some class change I will update it

The point is to make snippets easily understood and maintained, also to keep it from bloating up with hashes as class names.

@kyrie25
Copy link
Member

kyrie25 commented Sep 3, 2022

Mapped lyrics classes via spicetify/cli#1911
@Tetrax-10 Please change your snippet accordingly so it can take effect next CLI release.

@Tetrax-10
Copy link
Contributor Author

Mapped lyrics classes via spicetify/spicetify-cli#1911 @Tetrax-10 Please change your snippet accordingly so it can take effect next CLI release.

updated

@theRealPadster theRealPadster merged commit 7b327ce into spicetify:main Sep 3, 2022
@Tetrax-10 Tetrax-10 deleted the Tetrax-vscode branch September 4, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants