Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snippet): add Right Side Cover Art #303

Merged
merged 5 commits into from
Aug 24, 2022
Merged

feat(snippet): add Right Side Cover Art #303

merged 5 commits into from
Aug 24, 2022

Conversation

Tetrax-10
Copy link
Contributor

Cover art on right side with animation

@Tetrax-10 Tetrax-10 requested a review from a team as a code owner August 24, 2022 13:17
@Tetrax-10 Tetrax-10 requested review from kyrie25 and removed request for a team August 24, 2022 13:17
Sorry forgot to remove comment

Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
@theRealPadster
Copy link
Member

Might I suggest naming it "right side cover art"? My first thought when I read the title was that it was updating incorrect cover art.

Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following Padster's suggestion, this is not forced so dw.

packages/marketplace/src/resources/snippets.ts Outdated Show resolved Hide resolved
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kyrie25 kyrie25 changed the title feat(snippet): add right cover art feat(snippet): add Right Side Cover Art Aug 24, 2022
@kyrie25 kyrie25 merged commit e4cc794 into spicetify:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants