Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Grid): add update checker #234

Merged
merged 16 commits into from
Jun 15, 2022
Merged

feat(Grid): add update checker #234

merged 16 commits into from
Jun 15, 2022

Conversation

kyrie25
Copy link
Member

@kyrie25 kyrie25 commented Jun 11, 2022

  • Feature update:
    Now checks for new updates every time Marketplace is opened and notifies the user via a button that leads to the repository:
    image

  • Styling update:
    Merge search bar onto header

  • TODO:

  • Use an SVG instead of available! for styling purposes(?)

  • Implement spcr-whats-new and manage changelogs

@kyrie25
Copy link
Member Author

kyrie25 commented Jun 12, 2022

Implemented spcr-whats-new to display a changelog modal every time it is updated. Should probably update the changelog to include this PR as well once it is merged.
image

Important note: Current version of Marketplace is not a valid SemVer version (I'm pretty sure it is, but it just doesn't accept version numbers below 1.0.0 🤷), so in order to trigger the modal, the version inside the Changelog component must be bumped simultaneously as the version number of Marketplace.
It is a valid SemVer number, I messed it up on my end but it's working as expected.
image

@kyrie25 kyrie25 marked this pull request as ready for review June 12, 2022 02:28
@kyrie25 kyrie25 requested a review from theRealPadster June 12, 2022 02:47
@kyrie25
Copy link
Member Author

kyrie25 commented Jun 12, 2022

Now uses GitHub commit log as changelog. Will need to squash commits in the future to reduce list length.
Need to change last commit timestamp on constant.ts so pinpoint when the version was bumped and the changes afterwards.
image

src/components/Modals/Changelog/index.tsx Outdated Show resolved Hide resolved
src/constants.ts Outdated Show resolved Hide resolved
@kyrie25 kyrie25 requested a review from theRealPadster June 15, 2022 02:43
@kyrie25 kyrie25 merged commit 595ddf5 into main Jun 15, 2022
@kyrie25 kyrie25 deleted the feat/update-check branch June 15, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants