feat(snippets): gawr gura karaoke #1012
Conversation
add gawr gura karaoke css
PiggMelonie
requested review from
theRealPadster
and removed request for
a team
|
If you will close this pull request and re-open it with new one, am definitely blocking you off our org |
WalkthroughAdded a new snippet entry "Gawr Gura Karaoke" to resources/snippets.json that injects a 60×60px GIF onto the playback progress bar via a ::before CSS rule, with positioning and pointer-events disabled; preview image referenced; no runtime logic changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
resources/snippets.json (1)
525-528: Avoid ::before collisions with other progress-bar overlaysMany snippets here also use ::before on .playback-progressbar. Switching to ::after reduces conflicts when users enable multiple overlays.
- "code": ".player-controls .playback-progressbar::before { content: ''; width: 60px; height: 50px; bottom: calc(100% - 7px); right: -5px; position: absolute; pointer-events: none; background-repeat: no-repeat; background-size: 60px 50px; background-image: url('https://media.tenor.com/qLco28DUQwUAAAAi/gura.gif'); }", + "code": ".player-controls .playback-progressbar::after { content: ''; width: 60px; height: 50px; bottom: calc(100% - 7px); right: -5px; position: absolute; pointer-events: none; background-repeat: no-repeat; background-size: 60px 50px; background-image: url('https://media.tenor.com/qLco28DUQwUAAAAi/gura.gif'); }",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
resources/assets/snippets/gurakaraoke.pngis excluded by!**/*.png
📒 Files selected for processing (1)
resources/snippets.json(1 hunks)
🔇 Additional comments (2)
resources/snippets.json (2)
523-524: Ignore trailing comma check—JSON is valid and the comma is already present.Likely an incorrect or invalid review comment.
528-529: Verify preview asset trackingThe file
resources/assets/snippets/gurakaraoke.pngis present, tracked in Git, and included in this PR change.
Im so sorry, ive never used github before and I kept getting errors with the lint. so i had to keep making new repositories even though im not sure that helped or if that was the only way. im sorry about that |
There was a problem hiding this comment.
If you need to make changes, go to your fork, and change files from there. Don't make new forks just to make some change
https://docs.openedx.org/en/latest/documentors/how-tos/make_changes_to_your_pull_request.html
resources/snippets.json
Outdated
| "title": "Gawr Gura Karaoke", | ||
| "description": "Adds a Gawr Gura Karaoke gif to the Progress Bar", | ||
| "code": ".player-controls .playback-progressbar::before { content: ''; width: 60px; height: 50px; bottom: calc(100% - 7px); right: -5px; position: absolute; pointer-events: none; background-repeat: no-repeat; background-size: 60px 50px; background-image: url('https://media.tenor.com/qLco28DUQwUAAAAi/gura.gif'); }", | ||
| "preview": "resources/assets/snippets/gurakaraoke.png" |
There was a problem hiding this comment.
The preview should be taken from the spotify client
There was a problem hiding this comment.
sorry for trying to do all this without really getting what to do, ive never attempted something like this. how would i upload the code to the client to be able to test it beforehand and take the preview?
There was a problem hiding this comment.
Marketplace -> Snippets tab -> Click Add CSS button -> Paste the string from code to it and save it with some name then enable it
There was a problem hiding this comment.
omg i didnt know i could do that the whole time. for like the last 12 hours ive been trying to mimic how all the requests are and trying to figure out what a pull request was and what stuff i had to edit. i thought for snippets id have to upload them to the marketplace for me to be able to even use them. again im super sorry about closing it over and over, my worst fear was that people would actually get notified of that, because i wasnt sure if they did. since ive already spent this long ill try my best to finish this pull anyways in case someone else wants to use it
changed gawr gura karaoke "preview" and "code"
add gawr gura karaoke gif above the progress bar
Summary by CodeRabbit