Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css-map): update & clean up #2758

Merged
merged 3 commits into from
Jan 10, 2024
Merged

feat(css-map): update & clean up #2758

merged 3 commits into from
Jan 10, 2024

Conversation

SunsetTechuila
Copy link
Contributor

afonsojramos
afonsojramos approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice, this is pretty awesome!! Please do open a PR to update the xpui archive with all of those versions. This will be crucial in the future if we want to use it as a basis for running automated tests against it!

@SunsetTechuila
Copy link
Contributor Author

Please do open a PR to update the xpui archive with all of those versions

i don't think it is possible lol

image

but you can just cherry pick my commits

@rxri rxri merged commit c6f9e69 into master Jan 10, 2024
9 checks passed
@rxri rxri deleted the map branch January 10, 2024 13:15
@afonsojramos
Copy link
Member

@SunsetTechuila just updated https://github.com/spicetify/spicetify-xpui-archive, let's try to keep it up to date, you also have write access!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@rxri rxri rxri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunsetTechuila @afonsojramos @rxri