Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply biome suggestions and fix few hooks #2751

Merged
merged 5 commits into from
Jan 8, 2024
Merged

feat: apply biome suggestions and fix few hooks #2751

merged 5 commits into from
Jan 8, 2024

Conversation

rxri
Copy link
Member

@rxri rxri commented Jan 5, 2024

Resolves #2750
This PR also fixes DragHandler availability from 1.2.1 to 1.2.8 and extractColorPreset on 1.2.5

biome*: https://biomejs.dev/linter/rules

@rxri rxri changed the title feat: apply biome suggestions and fix PlaylistMenu feat: apply biome suggestions and fix few hooks Jan 6, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but if we're changing to biome, which I support, we could probably fully move to biome, which means workflows and config.

@rxri
Copy link
Member Author

rxri commented Jan 8, 2024

I mean I just used biome linter suggestions but we can do that if you want

@rxri
Copy link
Member Author

rxri commented Jan 8, 2024

Will do it in another pull request since it will take a while

@rxri rxri merged commit b37ab4d into master Jan 8, 2024
10 checks passed
@rxri rxri deleted the feat/wrapper branch January 8, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants