Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrapper): nullify Player.data if playing item is null #2732

Merged
merged 1 commit into from
Dec 26, 2023
Merged

fix(wrapper): nullify Player.data if playing item is null #2732

merged 1 commit into from
Dec 26, 2023

Conversation

SunsetTechuila
Copy link
Contributor

No description provided.

@SunsetTechuila SunsetTechuila changed the title fix(wrapper): don't assign event data to Player.data if item is null fix(wrapper): assign null to Player.data if event playing item is null Dec 26, 2023
@SunsetTechuila SunsetTechuila changed the title fix(wrapper): assign null to Player.data if event playing item is null fix(wrapper): assign null to Player.data if playing item is null Dec 26, 2023
@SunsetTechuila
Copy link
Contributor Author

tell me if i shouldn't dispatch songchange/onplaypause events

@rxri rxri changed the title fix(wrapper): assign null to Player.data if playing item is null fix(wrapper): nullify Player.data if playing item is null Dec 26, 2023
@rxri rxri merged commit c8abbf1 into spicetify:master Dec 26, 2023
7 checks passed
@SunsetTechuila SunsetTechuila deleted the fix-player branch December 26, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants