Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update rework #2638

Merged
merged 5 commits into from
Nov 8, 2023
Merged

feat: update rework #2638

merged 5 commits into from
Nov 8, 2023

Conversation

afonsojramos
Copy link
Member

Following the discussions on #2528 and on Discord, this PR removes the --check-update flag and makes the upgrade/update semi-chainable. Also renamed the old update to refresh as it felt that it was the word that made the most sense based on what the function did and the PoV of the user.

@rxri
Copy link
Member

rxri commented Nov 7, 2023

we need to keep in mind that it will require changing section about upgrading spicetify in docs

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented Nov 7, 2023

reading is hard

@afonsojramos
Copy link
Member Author

afonsojramos commented Nov 7, 2023

@rxri
Copy link
Member

rxri commented Nov 7, 2023

rxri
rxri previously approved these changes Nov 8, 2023
@rxri rxri dismissed their stale review November 8, 2023 17:13

change was reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants