Postgres: enforce required NUMERIC type for round scalar function
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
changed the title
NUMERIC type for round scalar function
sgrebnov
force-pushed
the
sgrebnov/fix-pg-round-unparsing
branch
from
cde4135
to
9e1bd7d
Compare
14 tasks
peasee
approved these changes
Sep 30, 2024
sgrebnov
force-pushed
the
sgrebnov/fix-pg-round-unparsing
branch
from
1d48a4a
to
a8f630a
Compare
sgrebnov
commented
Oct 3, 2024
phillipleblanc
approved these changes
Oct 3, 2024
sgrebnov
added a commit
that referenced
this pull request
Oct 3, 2024
…#34) Includes initial support for dialects to override scalar functions unparsing
sgrebnov
added a commit
that referenced
this pull request
Oct 15, 2024
* Postgres: enforce required `NUMERIC` type for `round` scalar function (#34) Includes initial support for dialects to override scalar functions unparsing * Document scalar_function_to_sql_overrides fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR fixes Postgres unparsing "Query Error function round(double precision, integer) does not exist" error by enforcing
NUMERICdata type forroundscalar function as Postgres does not supportFloatarguments and requiresNUMERIC.https://www.postgresql.org/docs/17/functions-math.html
Closes spiceai/spiceai#2844