Add pre/post processors to allow nan and inf values to be stored in JSON #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MSONable` class, provided by the `monty` library, is designed to make arbitrary classes easily JSON-serializable such that they can be serialized and, for example, stored in a database. The class is used extensively in `pymatgen` and many of their classes are MSONable. Since the `pymatgen` classes are used often in the current AiiDA community, it would be nice if these objects can be easily stored in the provenance graph. The new `MsonableData` data plugin, wraps any instance of a `MSONable` class. When constructed, it calls `as_dict` which by definition returns a JSON-serialized version of the object, which we can therefore store in the nodes attributes and allow it to be stored. The `obj` property will return the original MSONable instance as it deserializes it from the serialized version stored in the attributes.
|
Thanks @zhubonan . I'm out of office this week but will take a look when I'm back |
Remove the subclass checking - only check for the as_dict and from_dict methods. Remove unecessary round trips for json encoding. We still assume that the output of `as_dict` is JSON serializable as originally intended by the `MSONable` class.
zhubonan
force-pushed
the
feature/4975/msonable-data-plugin-bonan
branch
from
be846b0 to
a15b525
Compare
sphuber
force-pushed
the
feature/4975/msonable-data-plugin
branch
from
385b4a4 to
d8f88f2
Compare
|
I have updated the PR to make a more generic plugin, i.e. to decouple it from |
sphuber
force-pushed
the
feature/4975/msonable-data-plugin
branch
4 times, most recently
from
b5a38cb to
6513a79
Compare
sphuber
force-pushed
the
feature/4975/msonable-data-plugin
branch
from
6513a79 to
9537ef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow nan/inf values to be stored as JSON strings in PostgreSQL.