Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ct): add ProxyAdmin #43

Merged
merged 2 commits into from
Aug 21, 2022
Merged

feat(ct): add ProxyAdmin #43

merged 2 commits into from
Aug 21, 2022

Conversation

sam-goldman
Copy link
Collaborator

@sam-goldman sam-goldman commented Aug 18, 2022

fixes #27

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@sam-goldman sam-goldman linked an issue Aug 19, 2022 that may be closed by this pull request
changeset

add `abi.encodeCall` to proxy admin

removed default proxy logic in Admin
Copy link
Collaborator

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit e7ee72d into develop Aug 21, 2022
@mergify mergify bot deleted the sg/ct-proxy-admin branch August 21, 2022 18:57
@mergify mergify bot removed the on-merge-train label Aug 21, 2022
sam-goldman added a commit that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ProxyAdmin contract
2 participants