Merge pull request #243 from chugsplash/sg/develop

fix(pg): fix BaseServiceV2 arg parsing bug in hardhat tasks

.changeset/old-ads-join.md

@@ -0,0 +1,5 @@
+---
+'@chugsplash/plugins': patch
+---
+
+Fixes a bug where the BaseServiceV2 was erroring when parsing command line args from the Hardhat plugin

packages/plugins/src/env.ts

@@ -0,0 +1,9 @@
+/**
+ * Removes all command line args in the `process.argv` array that begin with '--'. This is necessary
+ * to prevent an error that occurs when running the executor from within a Hardhat plugin task. This
+ * error occurs because the BaseServiceV2 (inherited by the executor) parses these command line
+ * arguments and throws an error when it sees arguments that it does not recognize.
+ */
+export const removeFlagsFromCommandLineArgs = (): void => {
+  process.argv = process.argv.filter((arg) => !arg.startsWith('--'))
+}

packages/plugins/src/hardhat/deployments.ts

@@ -34,6 +34,7 @@ import {
   monitorTask,
   TASK_CHUGSPLASH_VERIFY_BUNDLE,
 } from './tasks'
+import { removeFlagsFromCommandLineArgs } from '../env'
 
 /**
  * TODO
@@ -207,6 +208,9 @@ export const deployChugSplashConfig = async (
       value: ethers.utils.parseEther('1'),
     })
 
+    // We must remove the command line arguments that begin with '--' from the process.argv array,
+    // or else the BaseServiceV2 (inherited by the executor) will throw an error.
+    removeFlagsFromCommandLineArgs()
     const executor = new ChugSplashExecutor()
     await executor.main(
       {

packages/plugins/src/index.ts

@@ -1,2 +1,3 @@
 export * from './hardhat'
 export * from './messages'
+export * from './env'