Fix release of Sphinx by forcing upgrades to dependencies #9439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
approved these changes
Jul 13, 2021
tk0miya
requested changes
Jul 13, 2021
| 'sphinxcontrib-devhelp>=1.0.2', | ||
| 'sphinxcontrib-jsmath>=1.0.1', | ||
| 'sphinxcontrib-htmlhelp>=2.0.0', | ||
| 'sphinxcontrib-serializinghtml>=1.1.5', |
There was a problem hiding this comment.
IMO, it's enough to pin only htmlhelp and serializinghtml.
There was a problem hiding this comment.
It seems like we should pin them all, so that we don't hit this issue in the future? I imagine there will also be breaking changes over time, and we want users to have the latest version. I don't feel strongly though.
This fixes sphinx-doc#9434, and should probably go into a new 4.1.1 release
|
I rebased on 4.1.x, since 4.0.x doesn't exist: |
|
OMG, this still contains commits on 4.x branch... |
|
I'm fixing this in another PR. Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
This fixes #9434, and should probably go into a new 4.1.1 release
Detail
We should probably have a proper versioning policy for these dependencies. Are they really all required? Should some be optional, and not break Sphinx if they aren't able to be imported?
It seems that each should probably be updated as a dependency on each Sphinx release, given that they cause breaking changes Sphinx if they get out of date.
Relates
#9434